[stylelint-polaris] Fix custom property allowed list plugin #7877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloerice
force-pushed
the
fix-custom-property-allowed-list-plugin
branch
from
27a8b35
to
cec64ab
Compare
11 tasks
sam-b-rose
added
the
stylelint-polaris
|
@chloerice this seems to be outdated. Is this still an issue we should prioritize? |
chloerice
force-pushed
the
fix-custom-property-allowed-list-plugin
branch
from
cec64ab
to
45b8fe6
Compare
…entionally 2 problems
sophschneider
approved these changes
Feb 17, 2023
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
…7877) ### WHY are these changes introduced? The `polaris/custom-property-allowed-list` plugin is currently reporting a single problem for what should be two different problems that can potentially exist in the same decl (`--p-test: var(--p-unknown);`): - one problem for definition of custom property name with disallowed prefix - `--p-test: var(--p-space-1);` - one problem for definition of custom property value with invalid Polaris token or private Polaris component token - `color: var(--p-unknown);` <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR: - Removes remnants of internal vs external configs - Reports problems with specific error messages for each of the two rule configuration options - Clarifies the intentions and configuration of the rule - Fixes the metadata URLs of custom rules ### 🎩 checklist - [x] Tested in VS Code (https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide - [x] Tested in terminal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
polaris/custom-property-allowed-listplugin is currently reporting a single problem for what should be two different problems that can potentially exist in the same decl (--p-test: var(--p-unknown);):--p-test: var(--p-space-1);color: var(--p-unknown);WHAT is this pull request doing?
This PR:
🎩 checklist