[BulkActions] Updates to border color and interactive states of the BulkActions Buttons #7891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
laurkim
reviewed
Dec 13, 2022
laurkim
approved these changes
Dec 13, 2022
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Merged
mrcthms
pushed a commit
that referenced
this pull request
Dec 14, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.16.0 ### Minor Changes - [#7893](#7893) [`9e617c4d9`](9e617c4) Thanks [@yurm04](https://github.com/yurm04)! - Updating TextField and Select border colors to be compliant with accessibility color contrast guidance - [#7910](#7910) [`5a4faf821`](5a4faf8) Thanks [@henryyi](https://github.com/henryyi)! - Added support for hover delay before displaying tooltip ### Patch Changes - [#7890](#7890) [`53d836dc2`](53d836d) Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed display bug with `BulkActions` when content in the table changes at the same time the bulk actions bar is visible - [#7846](#7846) [`65131df18`](65131df) Thanks [@qt314](https://github.com/qt314)! - - Changed border radius of `focus-ring` to use shape tokens instead of adding an extra `1px` - Updated `TextField` placeholder text to not change to a custom color on error - Delete an unused class in the `DataTable` and `IndexTable` - Replace some `px` values with tokens - Add some stylelint ignore context comments - [#7891](#7891) [`ff82bdb18`](ff82bdb) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the colors of the borders of the buttons in the `BulkActions` component ## @shopify/plugin-polaris@0.0.21 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.10.1 ## @shopify/polaris-migrator@0.10.1 ### Patch Changes - Updated dependencies \[[`4b96147b3`](4b96147), [`c8a294f51`](c8a294f), [`6cd75fd9a`](6cd75fd), [`bdf04a289`](bdf04a2), [`9206b7b13`](9206b7b)]: - @shopify/stylelint-polaris@5.0.1 ## @shopify/stylelint-polaris@5.0.1 ### Patch Changes - [#7866](#7866) [`4b96147b3`](4b96147) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `stylelint-polaris` to allow disabling specific coverage rules instead of entire categories - [#7906](#7906) [`c8a294f51`](c8a294f) Thanks [@qt314](https://github.com/qt314)! - Fixed config atRule and function regex to match whole word - [#7868](#7868) [`6cd75fd9a`](6cd75fd) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Update `package.json` to define a single entry point - [#7696](#7696) [`bdf04a289`](bdf04a2) Thanks [@chloerice](https://github.com/chloerice)! - Implemented custom message configuration support for polaris/coverage plugin - [#7898](#7898) [`9206b7b13`](9206b7b) Thanks [@qt314](https://github.com/qt314)! - Bug fix to wrap z-index 'declaration-property-value-allowed-list' token value with "var" ## polaris.shopify.com@0.27.2 ### Patch Changes - Updated dependencies \[[`53d836dc2`](53d836d), [`9e617c4d9`](9e617c4), [`5a4faf821`](5a4faf8), [`65131df18`](65131df), [`ff82bdb18`](ff82bdb)]: - @shopify/polaris@10.16.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
…ulkActions Buttons (Shopify#7891) ### WHY are these changes introduced? After receiving feedback that the buttons in the Bulk Actions look a little harsh, @ouellettejordan and I jammed on a subtler treatment for these buttons. We now use the `--p-border-on-dark` value for our border colors, and updated hover/pressed colors for the hover and active states of the buttons. ### WHAT is this pull request doing? <img width="1915" alt="Updated Bulk Actions UI with darker border color visible" src="https://user-images.githubusercontent.com/2562596/207084323-ac35bb77-2ccf-42cf-84e2-d980adb159ea.png"> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide Co-authored-by: Lo Kim <lo.kim@shopify.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.16.0 ### Minor Changes - [Shopify#7893](Shopify#7893) [`9e617c4d9`](Shopify@9e617c4) Thanks [@yurm04](https://github.com/yurm04)! - Updating TextField and Select border colors to be compliant with accessibility color contrast guidance - [Shopify#7910](Shopify#7910) [`5a4faf821`](Shopify@5a4faf8) Thanks [@henryyi](https://github.com/henryyi)! - Added support for hover delay before displaying tooltip ### Patch Changes - [Shopify#7890](Shopify#7890) [`53d836dc2`](Shopify@53d836d) Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed display bug with `BulkActions` when content in the table changes at the same time the bulk actions bar is visible - [Shopify#7846](Shopify#7846) [`65131df18`](Shopify@65131df) Thanks [@qt314](https://github.com/qt314)! - - Changed border radius of `focus-ring` to use shape tokens instead of adding an extra `1px` - Updated `TextField` placeholder text to not change to a custom color on error - Delete an unused class in the `DataTable` and `IndexTable` - Replace some `px` values with tokens - Add some stylelint ignore context comments - [Shopify#7891](Shopify#7891) [`ff82bdb18`](Shopify@ff82bdb) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the colors of the borders of the buttons in the `BulkActions` component ## @shopify/plugin-polaris@0.0.21 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.10.1 ## @shopify/polaris-migrator@0.10.1 ### Patch Changes - Updated dependencies \[[`4b96147b3`](Shopify@4b96147), [`c8a294f51`](Shopify@c8a294f), [`6cd75fd9a`](Shopify@6cd75fd), [`bdf04a289`](Shopify@bdf04a2), [`9206b7b13`](Shopify@9206b7b)]: - @shopify/stylelint-polaris@5.0.1 ## @shopify/stylelint-polaris@5.0.1 ### Patch Changes - [Shopify#7866](Shopify#7866) [`4b96147b3`](Shopify@4b96147) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `stylelint-polaris` to allow disabling specific coverage rules instead of entire categories - [Shopify#7906](Shopify#7906) [`c8a294f51`](Shopify@c8a294f) Thanks [@qt314](https://github.com/qt314)! - Fixed config atRule and function regex to match whole word - [Shopify#7868](Shopify#7868) [`6cd75fd9a`](Shopify@6cd75fd) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Update `package.json` to define a single entry point - [Shopify#7696](Shopify#7696) [`bdf04a289`](Shopify@bdf04a2) Thanks [@chloerice](https://github.com/chloerice)! - Implemented custom message configuration support for polaris/coverage plugin - [Shopify#7898](Shopify#7898) [`9206b7b13`](Shopify@9206b7b) Thanks [@qt314](https://github.com/qt314)! - Bug fix to wrap z-index 'declaration-property-value-allowed-list' token value with "var" ## polaris.shopify.com@0.27.2 ### Patch Changes - Updated dependencies \[[`53d836dc2`](Shopify@53d836d), [`9e617c4d9`](Shopify@9e617c4), [`5a4faf821`](Shopify@5a4faf8), [`65131df18`](Shopify@65131df), [`ff82bdb18`](Shopify@ff82bdb)]: - @shopify/polaris@10.16.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
After receiving feedback that the buttons in the Bulk Actions look a little harsh, @ouellettejordan and I jammed on a subtler treatment for these buttons. We now use the
--p-border-on-darkvalue for our border colors, and updated hover/pressed colors for the hover and active states of the buttons.WHAT is this pull request doing?
🎩 checklist
README.mdwith documentation changes