-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove downlevel-dts and legacy type support #8203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also delete the typesVersions config from the package.json too - https://github.com/Shopify/polaris/blob/main/polaris-react/package.json#L40-L46
Is this an opportunity to also adjust the type output location? Currently they're in build/ts/latest
(per https://github.com/Shopify/polaris/blob/main/polaris-react/tsconfig.json#L7 (which says where TS should create them) and https://github.com/Shopify/polaris/blob/main/polaris-react/package.json#L39 (which says where consumers can find them). perhaps that can be shortened to build/ts
now?
Co-Authored-By: Ben Scott <227292+BPScott@users.noreply.github.com>
Co-Authored-By: Ben Scott <227292+BPScott@users.noreply.github.com>
2fef975
to
85b557a
Compare
size-limit report 📦
|
## @shopify/polaris v11.0.0 ### Dependencies - [x] #8200 ### NodeJS - [x] #8201 ### TypeScript - [x] #8203 ### Components - [x] #7349 - [x] #7397 - [x] #7962 - [x] #8187 - [x] #8184 - [x] #8206 - [x] #7990 - [x] #8468 - [x] #8577 - [x] #8631 - [x] #8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] #6920 - [x] #8245 - [x] #4826 - [x] #8405 ## @shopify/stylelint-polaris v7.0.0 - [x] #7622 - [x] #8419 # Post @shopify/polaris v11 shipping - [ ] #8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com> Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com> Co-authored-by: Ryan Musgrave <ryanm128@gmail.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Matt Gregg <matt.gregg@shopify.com> Co-authored-by: Alex Page <hi@alexpage.dev> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com> Co-authored-by: Sam Rose <sam.rose@shopify.com> Co-authored-by: Marc Thomas <marc.thomas@shopify.com> Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com> Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com> Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com> Co-authored-by: Joe Thomas <joe.thomas@shopify.com> Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
## @shopify/polaris v11.0.0 ### Dependencies - [x] Shopify#8200 ### NodeJS - [x] Shopify#8201 ### TypeScript - [x] Shopify#8203 ### Components - [x] Shopify#7349 - [x] Shopify#7397 - [x] Shopify#7962 - [x] Shopify#8187 - [x] Shopify#8184 - [x] Shopify#8206 - [x] Shopify#7990 - [x] Shopify#8468 - [x] Shopify#8577 - [x] Shopify#8631 - [x] Shopify#8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] Shopify#6920 - [x] Shopify#8245 - [x] Shopify#4826 - [x] Shopify#8405 ## @shopify/stylelint-polaris v7.0.0 - [x] Shopify#7622 - [x] Shopify#8419 # Post @shopify/polaris v11 shipping - [ ] Shopify#8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com> Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com> Co-authored-by: Ryan Musgrave <ryanm128@gmail.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Matt Gregg <matt.gregg@shopify.com> Co-authored-by: Alex Page <hi@alexpage.dev> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com> Co-authored-by: Sam Rose <sam.rose@shopify.com> Co-authored-by: Marc Thomas <marc.thomas@shopify.com> Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com> Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com> Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com> Co-authored-by: Joe Thomas <joe.thomas@shopify.com> Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
WHY are these changes introduced?
Polaris currently supports multiple TypeScript versions by building our types twice. This breaking change in v11 removes this functionality and we will only support the current version in the library.
This used to be required to build the props table on legacy.polaris.shopify.com. This is no longer a requirement with @martenbjork brilliant work.
WHAT is this pull request doing?
Removes legacy type support for the library.