[BulkActions] Use light UI over dark UI #8233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @mrcthms! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230201154144yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20230201154144yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230201154144yarn add @shopify/polaris@0.0.0-snapshot-release-20230201154144yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230201154144yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230201154144 |
size-limit report 📦
|
|
/snapit |
|
🫰✨ Thanks @mrcthms! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230201170836yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20230201170836yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230201170836yarn add @shopify/polaris@0.0.0-snapshot-release-20230201170836yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230201170836yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230201170836 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We want to revert the BulkActions component to use a light UI over a dark UI. We initially opted for a dark UI for this to improve discoverability of the component, however we now feel it's more appropriate to maintain consistency with the rest of the UI and keeping it light. In order to ensure the component still feels noticable when appearing, especially over intermediate-ly checked IndexTables, we have added a new shadow token
--p-shadow-mediumwhich is used to visually lift the BulkActions.WHAT is this pull request doing?
Removing all custom properties which switched the BulkActions UI to be dark, and adding in the new shadow token.
🎩 checklist
README.mdwith documentation changes