[IndexTable] Fix header cutting off loading banner due to z-index #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
[note] Checked this z-index against sticky headers to make sure those dont overlap either |
|
/snapit |
|
🫰✨ Thanks @LauraAubin! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230215161735yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20230215161735yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230215161735yarn add @shopify/polaris@0.0.0-snapshot-release-20230215161735yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230215161735yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230215161735 |
LauraAubin
reviewed
Feb 15, 2023
stefanlegg
force-pushed
the
sl-loading-z
branch
from
28bc94c
to
868e7a9
Compare
stefanlegg
force-pushed
the
sl-loading-z
branch
from
868e7a9
to
52ce8d2
Compare
LauraAubin
approved these changes
Feb 16, 2023
ChrisMLee
approved these changes
Feb 17, 2023
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
…opify#8364) ### WHY are these changes introduced? Related to: Shopify#8277 In order to support some tooltip behavior the z-index changed for table headers. Loading banners need to have their z-index moved up to not be cut off by the header. Example issue:  ### WHAT is this pull request doing? This PR removes `--pc-index-table-loading-panel` and the loading banner will now use `--p-z-2` for z-index instead. Example with fix:  ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to: #8277
In order to support some tooltip behavior the z-index changed for table headers. Loading banners need to have their z-index moved up to not be cut off by the header.
Example issue:
WHAT is this pull request doing?
This PR removes
--pc-index-table-loading-paneland the loading banner will now use--p-z-2for z-index instead.Example with fix:
🎩 checklist
README.mdwith documentation changes