Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate z-index custom properties from v10 to v11 #8423

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

lgriffee
Copy link
Member

WHY are these changes introduced?

Part of #8405

WHAT is this pull request doing?

Runs the v11-styles-replace-custom-property-zindex from @shopify/polaris-migrator to migrate z-index custom properties from v10 to v11. e.g.

cd polaris-react

npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230217170608 \ 
v11-styles-replace-custom-property-zindex \
'./src/**/*.scss'

npx prettier --write "./src/**/*.scss"

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

size-limit report 📦

Path Size
polaris-react-cjs 220.13 KB (-0.1% 🔽)
polaris-react-esm 139.98 KB (-0.1% 🔽)
polaris-react-esnext 195.85 KB (-0.11% 🔽)
polaris-react-css 42.35 KB (-0.2% 🔽)

@lgriffee lgriffee merged commit bc8ab02 into main Feb 17, 2023
@lgriffee lgriffee deleted the replace-zindex-custom-properties branch February 17, 2023 22:49
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
### WHY are these changes introduced?

Part of Shopify#8405 

### WHAT is this pull request doing?

Runs the
[`v11-styles-replace-custom-property-zindex`](Shopify#8272)
from `@shopify/polaris-migrator` to migrate `z-index` custom properties
from `v10` to `v11`. e.g.

```sh
cd polaris-react

npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230217170608 \ 
v11-styles-replace-custom-property-zindex \
'./src/**/*.scss'

npx prettier --write "./src/**/*.scss"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants