Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually migrate z-index custom properties from v10 to v11 #8425

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

lgriffee
Copy link
Member

WHY are these changes introduced?

Part of #8405

WHAT is this pull request doing?

Finds and replaces any instances of legacy z-index custom properties in non SCSS files with the repalcement map from v11-styles-replace-custom-property-zindex

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

size-limit report 📦

Path Size
polaris-react-cjs 220.35 KB (0%)
polaris-react-esm 140.12 KB (0%)
polaris-react-esnext 196.07 KB (+0.01% 🔺)
polaris-react-css 42.44 KB (+0.02% 🔺)

Base automatically changed from replace-zindex-custom-properties to main February 17, 2023 22:49
@lgriffee lgriffee merged commit c73717c into main Feb 17, 2023
@lgriffee lgriffee deleted the manually-replace-zindex-custom-properties branch February 17, 2023 23:08
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
…pify#8425)

### WHY are these changes introduced?

Part of Shopify#8405 <!-- link to issue if one exists -->

### WHAT is this pull request doing?
Finds and replaces any instances of legacy `z-index` custom properties
in non SCSS files with the repalcement map from
[`v11-styles-replace-custom-property-zindex`](Shopify#8272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants