[Icon] Add "Magic" colour to the Icon component #8546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 馃摝
|
MindRave
changed the title
kyledurand
approved these changes
Mar 3, 2023
Merged
kyledurand
pushed a commit
that referenced
this pull request
Mar 7, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.34.0 ### Minor Changes - [#8546](#8546) [`8872c0861`](8872c08) Thanks [@MindRave](https://github.com/MindRave)! - Added "magic" color to the Icon component's color prop type. - [#8545](#8545) [`7c174e47a`](7c174e4) Thanks [@alex-page](https://github.com/alex-page)! - Updated DropZone with a signifigant restructure to remove Class child component - [#8525](#8525) [`8a4de8168`](8a4de81) Thanks [@rcaplanshopify](https://github.com/rcaplanshopify)! - [IndexTable] Adds support for header config object alignment property and treatment of right-aligned, sortable column headings - [#8569](#8569) [`646fba23f`](646fba2) Thanks [@kyledurand](https://github.com/kyledurand)! - Allowed aria attributes on Bleed, Inline, and Columns ### Patch Changes - [#8581](#8581) [`336d14545`](336d145) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a bug where bulk actions wouldn't render when only promoted actions exist ## @shopify/polaris-cli@0.1.15 ## polaris.shopify.com@0.38.1 ### Patch Changes - [#8570](#8570) [`45ca38d41`](45ca38d) Thanks [@laurkim](https://github.com/laurkim)! - Added `Legacy` status to component lifecycle page and banner/badge to `LegacyStack` and `LegacyCard` - [#8573](#8573) [`0389fd8b8`](0389fd8) Thanks [@laurkim](https://github.com/laurkim)! - Fixed links to component lifecycle page in alpha component banners - Updated dependencies \[[`336d14545`](336d145), [`8872c0861`](8872c08), [`7c174e47a`](7c174e4), [`8a4de8168`](8a4de81), [`646fba23f`](646fba2)]: - @shopify/polaris@10.34.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
### WHY are these changes introduced? Fixes [Shopify#629](https://github.com/Shopify/storefront-setup/issues/629) The Icon component doesn't have the "Magic" colour yet, whereas the tokens are already available for use. We should add "magic" to the colour prop and the CSS. ### WHAT is this pull request doing? <img src="https://shopify.click/03-54-46fx7-wqvbe.png" width="300" /> - Added `magic` entry to the Icon color prop type. - Added corresponding CSS rule. - Added Storybook variant. ### 馃帺 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) N/A - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) N/A - [ ] Updated the component's `README.md` with documentation changes N/A - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide N/A
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.34.0 ### Minor Changes - [Shopify#8546](Shopify#8546) [`8872c0861`](Shopify@8872c08) Thanks [@MindRave](https://github.com/MindRave)! - Added "magic" color to the Icon component's color prop type. - [Shopify#8545](Shopify#8545) [`7c174e47a`](Shopify@7c174e4) Thanks [@alex-page](https://github.com/alex-page)! - Updated DropZone with a signifigant restructure to remove Class child component - [Shopify#8525](Shopify#8525) [`8a4de8168`](Shopify@8a4de81) Thanks [@rcaplanshopify](https://github.com/rcaplanshopify)! - [IndexTable] Adds support for header config object alignment property and treatment of right-aligned, sortable column headings - [Shopify#8569](Shopify#8569) [`646fba23f`](Shopify@646fba2) Thanks [@kyledurand](https://github.com/kyledurand)! - Allowed aria attributes on Bleed, Inline, and Columns ### Patch Changes - [Shopify#8581](Shopify#8581) [`336d14545`](Shopify@336d145) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a bug where bulk actions wouldn't render when only promoted actions exist ## @shopify/polaris-cli@0.1.15 ## polaris.shopify.com@0.38.1 ### Patch Changes - [Shopify#8570](Shopify#8570) [`45ca38d41`](Shopify@45ca38d) Thanks [@laurkim](https://github.com/laurkim)! - Added `Legacy` status to component lifecycle page and banner/badge to `LegacyStack` and `LegacyCard` - [Shopify#8573](Shopify#8573) [`0389fd8b8`](Shopify@0389fd8) Thanks [@laurkim](https://github.com/laurkim)! - Fixed links to component lifecycle page in alpha component banners - Updated dependencies \[[`336d14545`](Shopify@336d145), [`8872c0861`](Shopify@8872c08), [`7c174e47a`](Shopify@7c174e4), [`8a4de8168`](Shopify@8a4de81), [`646fba23f`](Shopify@646fba2)]: - @shopify/polaris@10.34.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #629
The Icon component doesn't have the "Magic" colour yet, whereas the tokens are already available for use. We should add "magic" to the colour prop and the CSS.
WHAT is this pull request doing?
magicentry to the Icon color prop type.馃帺 checklist
README.mdwith documentation changes N/A