Add diffThreshold to storybook #8778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
kyledurand
force-pushed
the
chromatic-add-diff-threshold
branch
5 times, most recently
from
74a2748
to
3a59a6a
Compare
kyledurand
force-pushed
the
chromatic-add-diff-threshold
branch
from
3a59a6a
to
571e14f
Compare
laurkim
approved these changes
Mar 29, 2023
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This is still a test but I think needs to be merged into main before we can compare against it. I will follow up with a test PR to test this. This new threshold will catch smaller changes like 4px border-radius changes that weren't caught in [this pr](Shopify#8626) I compared the two snapshots using the chromatic tool [here](https://6262c53f521620003ac2ff49-ukmsdlppcb.chromatic.com/?path=/story/stories-diff-threshold-check--test-yours-out) https://user-images.githubusercontent.com/6844391/228541322-b5fddce0-10cb-4b41-bfda-8873ee6651b0.mp4
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
This is still a test but I think needs to be merged into main before we can compare against it. I will follow up with a test PR to test this. This new threshold will catch smaller changes like 4px border-radius changes that weren't caught in [this pr](Shopify#8626) I compared the two snapshots using the chromatic tool [here](https://6262c53f521620003ac2ff49-ukmsdlppcb.chromatic.com/?path=/story/stories-diff-threshold-check--test-yours-out) https://user-images.githubusercontent.com/6844391/228541322-b5fddce0-10cb-4b41-bfda-8873ee6651b0.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a test but I think needs to be merged into main before we can compare against it. I will follow up with a test PR to test this. This new threshold will catch smaller changes like 4px border-radius changes that weren't caught in this pr
I compared the two snapshots using the chromatic tool here
threshold.mp4