Skip to content

Commit

Permalink
remove TODO from search
Browse files Browse the repository at this point in the history
  • Loading branch information
alexmgrant committed Jun 6, 2024
1 parent 015d013 commit 632c9e6
Show file tree
Hide file tree
Showing 8 changed files with 417 additions and 481 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/_site
/docs/_data/unstable
/docs/.jekyll-metadata
node_modules

# Ignore bundler config.
/.bundle
Expand Down
19 changes: 5 additions & 14 deletions bin/generate_docs
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@

require_relative "../config/environment"
require_relative "../config/cli"
require_relative "../lib/docs/mappings"

UNSTABLE = "unstable"

mappings = Docs::Mappings.new

cli = CLI.new([:version]) do |opts|
opts.on("-V VERSION", "--version=VERSION", "Version of the documentation")
end
Expand All @@ -19,14 +22,8 @@ cli.options_status
taxonomy_data = cli.parse_json("dist/en/taxonomy.json")
category_data = taxonomy_data.fetch("verticals")
attribute_data = taxonomy_data.fetch("attributes")

# mappings_data = cli.parse_json("dist/mappings.json").fetch("mappings").each do |mapping|
# if mapping["output_taxonomy"].include?("shopify")
# mapping["rules"].each do |rule|
# rule['input'], rule['output'] = rule['output'], rule['input']
# end
# end
# end
mappings_json = cli.parse_json("dist/en/integrations/all_mappings.json").fetch("mappings")
mappings_data = mappings.reverse_shopify_mapping_rules(mappings_json)

DATA_TARGET = "docs/_data/#{cli.options.version}"
cli.write_file("#{DATA_TARGET}/sibling_groups.yml") do |file|
Expand Down Expand Up @@ -56,9 +53,3 @@ unless cli.options.version == UNSTABLE
file.write(content)
end
end

def reverse_mapping_rules(rules)
rules.each do |rule|
rule["input"], rule["output"] = rule["output"], rule["input"]
end
end
4 changes: 4 additions & 0 deletions dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ up:
# doesn't give us a great way to force an upgrade.
met?: '! ( cue version 2>/dev/null | grep -E "cue version v0\.[123456]\." )'
meet: brew uninstall cue
- node:
version: v20.12.2
pnpm: 8.15.5
package_manager: pnpm@8.15.5
- packages:
- cue

Expand Down
23 changes: 13 additions & 10 deletions docs/_layouts/release.html
Original file line number Diff line number Diff line change
Expand Up @@ -117,16 +117,19 @@ <h3 class="attribute-title attribute-title--box" tabindex="0">
<div class="values-container values-container--box">
<ul class="values-container__list values-container__list--box">
{% for rule in rules %}
{% assign input_id = rule.input.product_category_id %}
{% assign output_id = rule.output.product_category_id %}
<li class="mapped-category hidden" id="{{ input_id }}">
<div class="mapped-category__id">
<h4 class="mapped-category__title">{{ output_title }} Taxonomy ID</h4>
<span class="id">{{ output_id }}</span>
</div>
<div class="mapped-category__version">ver {{ output_version }}</div>
<h4 class="mapped-category__title">Breadcrumb</h4>
</li>
{% assign input_id = rule.input.category.id %}
{% assign outputs = rule.output.category %}
{% for output in outputs %}
<li class="mapped-category hidden" id="{{ input_id }}">
<div class="mapped-category__id">
<h4 class="mapped-category__title">{{ output_title }} Taxonomy ID</h4>
<span class="id">{{ output.id }}</span>
</div>
<div class="mapped-category__version">ver {{ output_version }}</div>
<h4 class="mapped-category__title">Breadcrumb</h4>
{{ output.full_name }}
</li>
{% endfor %}
{% endfor %}
</ul>
</div>
Expand Down
4 changes: 1 addition & 3 deletions docs/assets/js/nodes.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,12 @@ const toggleVisibleSelectedCategory = () => {
};

const toggleVisibleAtrributes = () => {
if (!selectedNode) return;

const attributeElements = readAttributeValuesElement();
const documentNode = q(`.category-node[id="${selectedNode}"]`);

if (!documentNode) {
return attributeElements.forEach((element) =>
element.classList.remove(className.visible),
element.classList.replace(className.visible, className.hidden),
);
}

Expand Down
2 changes: 1 addition & 1 deletion docs/assets/js/search.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ async function categorySearch(query) {
results.forEach(({item}) => {
const searchResult = document.createElement('li');
const searchLink = document.createElement('a');
// TODO: use item.matches to highlight the matched characters

searchLink.textContent = item.title;
searchLink.href = item.url;
searchLink.onclick = (e) => {
Expand Down
34 changes: 34 additions & 0 deletions lib/docs/mappings.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
module Docs
class Mappings
def reverse_shopify_mapping_rules(mappings)
mappings.each do |mapping|
if shopify_mapping?(mapping)
reverse_mapping_rules(mapping)
end
end
end

def reverse_mapping_rules(mapping)
mapping["rules"].each do |rule|
rule["output"]["category"].each_with_index do |output, index|
if index == 0
rule["input"], rule["output"] = { "category" => output }, {"category" => [rule["input"]["category"]]}
else
mapping.push = build_rule(input: output, output: rule["input"]["category"])
end
end
end
end

def shopify_mapping?(mapping)
mapping["output_taxonomy"].include?("shopify")
end

def build_rule(input:, output:)
{
"input" => {"category" => input},
"output" => {"category" => [output]}
}
end
end
end

0 comments on commit 632c9e6

Please sign in to comment.