Add values.yml and update seeding to use it #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsom25
reviewed
Mar 21, 2024
|
Should we also pop attributes and values out of folders? |
tylerrowsell
approved these changes
Mar 25, 2024
| red = value!(id: 11, name: "Red") | ||
| zoo = value!(id: 12, name: "Zoo") | ||
| other = value!(id: 10, name: "Other") | ||
| red = value!(id: 11, name: "Red", friendly_id: "test__red") |
There was a problem hiding this comment.
Curious why we chose double underscore?
There was a problem hiding this comment.
I assume it's to help make it clear where the attribute name ends and the value name begins.
This was the format that I saw used in the slack conversation, so I carried it over here and to the parser
KComrade53
force-pushed
the
kc/values-yaml
branch
from
7e1b2ee
to
127da6e
Compare
|
Branch has been rebased off the latest changes to I'm going to fix the sort ordering for categories in the parser and add that to this PR |
tylerrowsell
approved these changes
Mar 25, 2024
|
Looks like data is still good 
|
elsom25
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new values.yml file under
data/valuesfor storing values and their ids instead of directly under attributes. The serializer and seeding logic has been updated to reflect these changes.The yaml files under
data/are also updated as part of this PR with the output of our new parser.Questions for reviewers