Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking category IDs in mappings are valid #206

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

Catherine-Fu
Copy link
Contributor

Checking categories IDs used in mappings are present in corresponding category files

  • add this consistency validation in an integration testing
  • this validation takes 0.29s

Testing result:

test_result

Copy link
Member

@tylerrowsell tylerrowsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this test will do the trick. I added some nits/notes on how you might be able to cleanup the code to make it more ruby like and DRY it up a little bit.

test/integration/mapping_validation_test.rb Outdated Show resolved Hide resolved
test/integration/mapping_validation_test.rb Outdated Show resolved Hide resolved
test/integration/mapping_validation_test.rb Outdated Show resolved Hide resolved
test/integration/mapping_validation_test.rb Outdated Show resolved Hide resolved
test/integration/mapping_validation_test.rb Outdated Show resolved Hide resolved
@Catherine-Fu Catherine-Fu merged commit 68f3fee into main Jun 6, 2024
5 checks passed
@Catherine-Fu Catherine-Fu deleted the mapping-validation branch June 6, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants