Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

githubpage #4

Merged
merged 1 commit into from
Jan 30, 2024
Merged

githubpage #4

merged 1 commit into from
Jan 30, 2024

Conversation

tylerrowsell
Copy link
Member

No description provided.

@caution-tape-bot
Copy link

👋 This PR might modify or add cookies to Shopify, and these changes might be subject to privacy regulations. If your PR is not related to cookies, feel free to ignore this message.

Please avoid adding any new cookies to merchant storefronts unless absolutely necessary, we are undergoing an effort as a company to reduce our cookie footprint for legal reasons.

If you're adding/removing cookie(s) to storefronts, admin or checkouts, reach to us in #help-cookie-compliance so we can study your use case. After that, update this cookies list.

Instructions on updating the cookies list can be found here.

If your repository is not related to storefronts, and instead is related to other surfaces like shopify.com, shop.app, etc. our tooling can't support purpose-based blocking for you yet. This means that we would still like you to add the cookie to the allow list so we can keep track of it, but you should:

  • Choose strictly_necessary as the purpose
  • Explain in the description of the cookie that you chose strictly necessary because there is no visitor consent available in the client surface of your cookie.
  • Use ["other"] for the surface of the cookie.

If you have any other questions, reach out to #help-cookie-compliance in slack so we can help you.

Thanks!


This comment was added by the CookieCompliance::CookieBlaster Caution Tape Bot rule.
View the source of this rule in Services DB

@caution-tape-bot
Copy link

👋 This PR might modify or add cookies to Shopify, and these changes might be subject to privacy regulations. If your PR is not related to cookies, feel free to ignore this message.

Please avoid adding any new cookies to merchant storefronts unless absolutely necessary, we are undergoing an effort as a company to reduce our cookie footprint for legal reasons.

If you're adding/removing cookie(s) to storefronts, admin or checkouts, reach to us in #help-cookie-compliance so we can study your use case. After that, update this cookies list.

Instructions on updating the cookies list can be found here.

If your repository is not related to storefronts, and instead is related to other surfaces like shopify.com, shop.app, etc. our tooling can't support purpose-based blocking for you yet. This means that we would still like you to add the cookie to the allow list so we can keep track of it, but you should:

  • Choose strictly_necessary as the purpose
  • Explain in the description of the cookie that you chose strictly necessary because there is no visitor consent available in the client surface of your cookie.
  • Use ["other"] for the surface of the cookie.

If you have any other questions, reach out to #help-cookie-compliance in slack so we can help you.

Thanks!


This comment was added by the CookieCompliance::CookieBlaster Caution Tape Bot rule.
View the source of this rule in Services DB

@tylerrowsell tylerrowsell force-pushed the github-page branch 2 times, most recently from 7c45dd7 to 4ad9a22 Compare January 30, 2024 03:28
src/index.html Outdated
Comment on lines 97 to 104
const fileNames = [
'shopify/categories/aa_apparel_accessories.yml',
'shopify/categories/hg_home_garden.yml',
'shopify/categories/sg_sporting_goods.yml',
'shopify/categories/undefined_food_beverages_tobacco.yml',
'shopify/categories/undefined_furniture.yml',
'shopify/categories/undefined_health_beauty.yml',
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't imagine we can do a glob in JS somehow? Or can leave this for when we switch to GH pages?

Copy link
Member Author

@tylerrowsell tylerrowsell Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so... since github pages is client side. They do have a github actions pipeline though.

We could also move it to dist we could rely on a single categories.yml instead though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also take the approach of generating /docs in a way that fits well with this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah... take a look at the latest push...

I've switched to use liquid and read from _data which can be automatically regenerated using a github action push on main.

Copy link
Collaborator

@elsom25 elsom25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -0,0 +1,35 @@
require 'yaml'
Copy link
Collaborator

@elsom25 elsom25 Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're gonna have a file in bin, let's make them executable:

  • Drop file extension: mv bin/generate_data.rb bin/generate_data
  • chmod +x bin/generate_data
  • Add shebang
Suggested change
require 'yaml'
#!/usr/bin/env ruby
require 'yaml'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this is in I'll start a PR to start extracting some of this to lib/ which can let us start splitting generation from file manipulations, etc etc

@elsom25
Copy link
Collaborator

elsom25 commented Jan 30, 2024

Liquid feels like a good use too given Shopify and all 😅 Love this thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants