-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
githubpage #4
githubpage #4
Conversation
bb16de5
to
12594e4
Compare
👋 This PR might modify or add cookies to Shopify, and these changes might be subject to privacy regulations. If your PR is not related to cookies, feel free to ignore this message. Please avoid adding any new cookies to merchant storefronts unless absolutely necessary, we are undergoing an effort as a company to reduce our cookie footprint for legal reasons. If you're adding/removing cookie(s) to storefronts, admin or checkouts, reach to us in #help-cookie-compliance so we can study your use case. After that, update this cookies list. Instructions on updating the cookies list can be found here. If your repository is not related to storefronts, and instead is related to other surfaces like shopify.com, shop.app, etc. our tooling can't support purpose-based blocking for you yet. This means that we would still like you to add the cookie to the allow list so we can keep track of it, but you should:
If you have any other questions, reach out to #help-cookie-compliance in slack so we can help you. Thanks! This comment was added by the |
12594e4
to
fa29dc4
Compare
👋 This PR might modify or add cookies to Shopify, and these changes might be subject to privacy regulations. If your PR is not related to cookies, feel free to ignore this message. Please avoid adding any new cookies to merchant storefronts unless absolutely necessary, we are undergoing an effort as a company to reduce our cookie footprint for legal reasons. If you're adding/removing cookie(s) to storefronts, admin or checkouts, reach to us in #help-cookie-compliance so we can study your use case. After that, update this cookies list. Instructions on updating the cookies list can be found here. If your repository is not related to storefronts, and instead is related to other surfaces like shopify.com, shop.app, etc. our tooling can't support purpose-based blocking for you yet. This means that we would still like you to add the cookie to the allow list so we can keep track of it, but you should:
If you have any other questions, reach out to #help-cookie-compliance in slack so we can help you. Thanks! This comment was added by the |
7c45dd7
to
4ad9a22
Compare
src/index.html
Outdated
const fileNames = [ | ||
'shopify/categories/aa_apparel_accessories.yml', | ||
'shopify/categories/hg_home_garden.yml', | ||
'shopify/categories/sg_sporting_goods.yml', | ||
'shopify/categories/undefined_food_beverages_tobacco.yml', | ||
'shopify/categories/undefined_furniture.yml', | ||
'shopify/categories/undefined_health_beauty.yml', | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't imagine we can do a glob in JS somehow? Or can leave this for when we switch to GH pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so... since github pages is client side. They do have a github actions pipeline though.
We could also move it to dist we could rely on a single categories.yml
instead though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also take the approach of generating /docs
in a way that fits well with this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah... take a look at the latest push...
I've switched to use liquid and read from _data
which can be automatically regenerated using a github action push on main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
e234306
to
75d9433
Compare
bin/generate_data.rb
Outdated
@@ -0,0 +1,35 @@ | |||
require 'yaml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're gonna have a file in bin, let's make them executable:
- Drop file extension:
mv bin/generate_data.rb bin/generate_data
chmod +x bin/generate_data
- Add shebang
require 'yaml' | |
#!/usr/bin/env ruby | |
require 'yaml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this is in I'll start a PR to start extracting some of this to lib/
which can let us start splitting generation from file manipulations, etc etc
Liquid feels like a good use too given Shopify and all 😅 Love this thank you |
75d9433
to
5b91978
Compare
5b91978
to
550f000
Compare
550f000
to
9afa871
Compare
No description provided.