Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React-i18n] Add defaultLocale option to babel plugin #1225

Merged
merged 1 commit into from
Apr 2, 2020
Merged

[React-i18n] Add defaultLocale option to babel plugin #1225

merged 1 commit into from
Apr 2, 2020

Conversation

nimzco
Copy link
Contributor

@nimzco nimzco commented Dec 21, 2019

Description

Fixes #1221

Add defaultLocale option to the babel plugin to change the default translation language.

Type of change

  • [React-i18n] Patch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)
  • [React-i18n] Minor: New feature (non-breaking change which adds functionality)
  • [React-i18n] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above

@ghost ghost added the cla-needed label Dec 21, 2019
@nimzco nimzco force-pushed the react-i18n/add_default_language_to_translation branch 2 times, most recently from 99e71a5 to a71ce91 Compare December 21, 2019 09:43
GoodForOneFare
GoodForOneFare approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@GoodForOneFare GoodForOneFare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks grand! My apologies for losing tracking of this over the festive break.

@nimzco
Copy link
Contributor Author

nimzco commented Jan 30, 2020

Thank you! No worries, I imagined the summit must have been quite a thing this year! 😇

@nimzco
Copy link
Contributor Author

nimzco commented Feb 27, 2020

Hey folks! I've signed the CLA, but the check has not updated. 😇

@ghost ghost removed the cla-needed label Apr 2, 2020
alexandcote
alexandcote approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@alexandcote alexandcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🎉 glad to still see your name in our project 😄

@alexandcote
Copy link
Contributor

alexandcote commented Apr 2, 2020 •
edited
Loading

Can you rebase your branch on master please? I don't seem to have access.

Edit: Got it 🎉

@alexandcote alexandcote force-pushed the react-i18n/add_default_language_to_translation branch from 02479a3 to 9fef520 Compare April 2, 2020 19:45
@alexandcote alexandcote merged commit dd7b69f into Shopify:master Apr 2, 2020
@nimzco
Copy link
Contributor Author

nimzco commented Apr 3, 2020

Thaaaanks!! 😍🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoodForOneFare GoodForOneFare GoodForOneFare approved these changes

@alexandcote alexandcote alexandcote approved these changes

@marutypes marutypes Awaiting requested review from marutypes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[react-i18n] Specify default locale to babel plugin
3 participants
@nimzco @alexandcote @GoodForOneFare