Correctly format future dates farther away than tomorrow #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
emroussel
commented
May 13, 2020
|
Hey, thanks for the PR! I think @jaxee built the current future date functionality, so she probably has good context to take a look :) PS sorry for the delay in getting to it. |
jaxee
reviewed
May 22, 2020
jaxee
reviewed
May 22, 2020
jaxee
reviewed
May 22, 2020
jaxee
reviewed
May 22, 2020
|
@jaxee thanks for the feedback, just updated the branch/PR! |
|
@jaxee do you have any more feedback? |
|
Great! What does the merge/release process look like (I don't have permission to merge since I don't have write access to this repo)? |
|
@emroussel I'll do a merge and release for you shortly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1429
Add support for these two cases in polaris guidelines for future dates in
i18n.formatDatewhen passingDateStyle.Humanize.Type of change
datesMinor: New feature (non-breaking change which adds functionality)react-i18nMajor: Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist