Use the entire hash when generating unique id #1905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing two issues:
generateID()
function used by the Babel plugin is grabbing the first 5 characters of the stringified hash for no reason. The string-hash library returns 32-bit unsigned numbers and the maximum length a stringified hash can get is just 7 ((0xffffffff).toString(36).length
) -- so there's really no point in trimming it to 5 characters. Trimming increases the chance of collision by 1296-fold (parseInt('100', 36)
).Number.MAX_SAFE_INTEGER
is0x1fffffffffffff
-- waaay over0xffffffff
:)Type of change
Checklist