allow to override worker public path #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-drexler
commented
Apr 2, 2024
| @@ -137,7 +137,9 @@ export function pitch(this: LoaderContext<Options>, request: string) { | |||
|
|
|||
| return callback!( | |||
| null, | |||
| `export default __webpack_public_path__ + ${JSON.stringify(entry)};`, | |||
| `export default (typeof __worker_public_path__ != "undefined" ? __worker_public_path__ : __webpack_public_path__) + ${JSON.stringify( | |||
There was a problem hiding this comment.
__webpack_public_path__ is guaranteed to exist, but __worker_public_path__ isn't, so we need to check if it exists before accessing it.
kumar303
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
🎩 This is working for me. Variable configuration adds flexibility to web workers so the build system can continue using __webpack_public_path__ in other places, undisturbed.
lemonmade
approved these changes
Apr 3, 2024
| @@ -12,6 +12,7 @@ const moduleWrapperCache = new Map<string, string | false>(); | |||
| export interface Options { | |||
| name?: string; | |||
| wrapperModule?: string; | |||
| magicGlobalPathVariable?: string; | |||
There was a problem hiding this comment.
Nitpicking on the name: maybe publicPathGlobal/ publicPathGlobalVariable? There isn’t necessarily any magic going on here, it can be any valid JS expression that will resolve to a string at runtime.
There was a problem hiding this comment.
renamed it to publicPathGlobalVariable
robin-drexler
force-pushed
the
rd/worker-path
branch
from
8781d9e
to
f019b98
Compare
znja
approved these changes
Apr 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to override
__worker_public_path__with a plugin option. This is needed for using a custom Extension sandbox URL while not changing other URLs in webpack's build (example).