Safely require cleanDocument/toSimpleDocument in graphql-mini-transforms #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orms The "jest" and "jest-simple" transforms for graphql-mini-transforms use __dirname in order to retrieve the absolute path to the relative file "document.js" when loading the cleanDocument and toSimpleDocument utilities. As a result, when the path to these files changes, such as when the package is updated under a manager like pnpm, the directory path will be different but the cache key will not change, causing it to try and use the Jest cached version of these files Since both cleanDocument and toSimpleDocument are exported at the top-level, we should just reference the `graphql-mini-transforms` package directly in the require statement.
|
/snapit |
vsumner
approved these changes
Apr 16, 2024
|
🫰✨ Thanks @ryanwilsonperkin! Your snapshothas been published to npm. Test the snapshot by updating your "graphql-mini-transforms": "0.0.0-snapshot-20240416154657" |
|
Confirmed working across node_modules changes |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2759
The "jest" and "jest-simple" transforms for graphql-mini-transforms use __dirname in order to retrieve the absolute path to the relative file "document.js" when loading the cleanDocument and toSimpleDocument utilities.
As a result, when the path to these files changes, such as when the package is updated under a manager like pnpm, the directory path will be different but the cache key will not change, causing it to try and use the Jest cached version of these files
Since both cleanDocument and toSimpleDocument are exported at the top-level, we should just reference the
graphql-mini-transformspackage directly in the require statement.