馃悰 no longer clobber koa context #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marutypes
force-pushed
the
fix-clobbering-koa-context
branch
2 times, most recently
from
0c84938
to
004d8ce
Compare
michenly
reviewed
Aug 20, 2019
|
|
||
| expect(ctx.body).toContain(myCoolApp); | ||
| }); | ||
|
|
||
| // we cannot test this with `createMockContext` because it actually clobbers the proxy methods itself :( |
There was a problem hiding this comment.
Is there an issue for this? Seems... problematic
There was a problem hiding this comment.
updated the PR, I was just doing it wrong and am a dumdum
michenly
approved these changes
Aug 20, 2019
lemonmade
approved these changes
Aug 20, 2019
packages/react-server/README.md
Outdated
| import App from '../app'; | ||
|
|
||
| const app = createServer({ | ||
| render: (ctx: RenderContext) => <App location={ctx.request.url} /> | ||
| render: (ctx: Context) => <App location={ctx.request.url} /> |
There was a problem hiding this comment.
You shouldn't ever need to specify the type explicitly here I don't think?
|
|
||
| expect(ctx.body).toContain(myCoolApp); | ||
| }); | ||
|
|
||
| // we cannot test this with `createMockContext` because it actually clobbers the proxy methods itself :( |
There was a problem hiding this comment.
Is there an issue for this? Seems... problematic
marutypes
force-pushed
the
fix-clobbering-koa-context
branch
from
2bdbed7
to
c044e4b
Compare
|
@michelleyschen can you take this one over? |
cartogram
force-pushed
the
fix-clobbering-koa-context
branch
8 times, most recently
from
59de437
to
c9de133
Compare
cartogram
force-pushed
the
fix-clobbering-koa-context
branch
from
c9de133
to
38ae3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #876
Description
This PR fixes the issue we were having where our use of the spread operator on the
ctxwe got passed by Koa broke a bunch of the proxying / getters on that object, leading things to not work unexpectedly and require delving intoctx.requestproperties directly.This PR is actually a breaking change, switching the API for
renderfunctions from(ctx: Koa.Context & {locale: string}) => JSXto(ctx: Koa.Context, data: {locale: string}).