Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print empty trees with comments #85

Merged
merged 1 commit into from
Oct 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rbi/printer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def accept_printer(v)
v.visit_all(comments)
end

unless root.empty?
unless root.empty? && root.comments.empty?
v.printn if strictness || !comments.empty?
v.visit(root)
end
Expand Down
11 changes: 11 additions & 0 deletions test/rbi/printer_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,17 @@ def test_print_empty_comments
RBI
end

def test_print_empty_trees_with_comments
rbi = RBI::File.new(strictness: "true")
rbi.root.comments << RBI::Comment.new("foo")

assert_equal(<<~RBI, rbi.string)
# typed: true

# foo
RBI
end

def test_print_params_inline_comments
comments = [RBI::Comment.new("comment")]

Expand Down