NS1: Generate resource record ids locally #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Makes it a little easier to focus in on certain tests.
- Encapsulate enough details on all forms of an answer form the NS1 API, so that we can get IDs in a uniform way from both full answers (from a `/zone/domain/type` call) and from short answers (from a `/zone/domain` call).
XaF
reviewed
Nov 25, 2019
Where possible, encapsulate answers from the NS1 API under our new abstraction, and fetch fields (like `id`) through this abstraction.
Answer ids just need to be comparable, so marshalling them just wastes time.
Tempted to make this a linter rule, but I'd be here all day.
XaF
approved these changes
Nov 26, 2019
|
Bumped version, and rotated my API key (whoops). Will ship at my next opportunity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our current approach for fetching the resource records in a zone requires:
ids for individual resource records.id's.How does this help?
id'ed so we can compute zone updates in a provider agnostic way, then perform the actual updates across all providers using thisid.record_storecompute theseids as a digest of the details of each resource record. Currently, the resource record set id, the resource record type and rrdata are used in the digest. Since theseid's are only used within eachrecord_storesession, we can improve the digest in the future if there are any problems.