Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and cleanup tests a bit #158

Merged
merged 4 commits into from Apr 14, 2020
Merged

refactor and cleanup tests a bit #158

merged 4 commits into from Apr 14, 2020

Conversation

sbfaulkner
Copy link
Contributor

  1. move the dummy config and zones for tests into test/fixtures/config to make it easier to have multiple configs
  2. make sure setup and teardown always call super like they should
  3. break test/test_helper.rb into support modules

cttttt
cttttt approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@cttttt cttttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for making things far cleaner on the test side.

@sbfaulkner sbfaulkner merged commit f048970 into master Apr 14, 2020
@sbfaulkner sbfaulkner deleted the test-refactor branch April 14, 2020 22:41
@sbfaulkner sbfaulkner temporarily deployed to production April 14, 2020 23:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cttttt cttttt cttttt approved these changes

@XaF XaF Awaiting requested review from XaF

@ryandv ryandv Awaiting requested review from ryandv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbfaulkner @cttttt