add command to validate authoritative DNS for providers #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XaF
reviewed
Apr 15, 2020
There was a problem hiding this comment.
This shouldn't flag:
Zone: shopify.cn
- NS1: authoritative nameservers not found for configured provider
- Unknown: unknown authoritative nameservers found
- dns4.g01.ns1global.org.
- dns1.g01.ns1global.org.
- dns2.g01.ns1global.org.
- dns3.g01.ns1global.org.
Probably would require other when there?
https://github.com/Shopify/record_store/pull/162/files/5aec3bc28217343f9cad4764be0d68753ea4e7f9#diff-5f6190009b4d6922fcd1b3bf4862de14R27-R28
when /\.nsone\.net\z/
when /\.ns1global\.org\z/
when /\.ns1global\.net\z/
'NS1'
Comment on lines
+8
to
+18
| case object | ||
| when Record::NS | ||
| object.nsdname.chomp('.') | ||
| else | ||
| begin | ||
| master_nameserver_for(object) | ||
| rescue Resolv::ResolvError | ||
| $stderr.puts "Domain doesn't exist (#{object})" | ||
| return | ||
| end | ||
| end |
There was a problem hiding this comment.
Why a case here instead of simple if?
There was a problem hiding this comment.
to easily match the types... and I'd originally considered when String for the current else case
I can definitely switch to if object.is_a?(Record::NS) instead 🤷
XaF
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds a
validate_authoritycommand to verify provider delegation to authoritative nameserversexample output...