-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for templating implicit records in a zone #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Tamrazov
force-pushed
the
add-support-for-templates
branch
from
November 30, 2020 18:51
aa99910
to
0362a68
Compare
XaF
reviewed
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you're currently working on adding tests. Here's a first batch of comments 😀
David-Tamrazov
force-pushed
the
add-support-for-templates
branch
7 times, most recently
from
December 1, 2020 14:50
d267961
to
875e6bd
Compare
David-Tamrazov
force-pushed
the
add-support-for-templates
branch
from
December 1, 2020 14:53
875e6bd
to
e1eb184
Compare
dschwar
reviewed
Dec 1, 2020
dschwar
approved these changes
Dec 1, 2020
XaF
reviewed
Dec 1, 2020
David-Tamrazov
force-pushed
the
add-support-for-templates
branch
from
December 1, 2020 17:27
e1eb184
to
b337bf8
Compare
XaF
approved these changes
Dec 1, 2020
David-Tamrazov
force-pushed
the
add-support-for-templates
branch
6 times, most recently
from
December 1, 2020 21:55
9ca2bf0
to
c9e2b81
Compare
David-Tamrazov
force-pushed
the
add-support-for-templates
branch
from
December 1, 2020 21:56
c9e2b81
to
04c47fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for injecting implicit records into a zone based on a template provided by the consumer. When building its record set, each
Zone
will now loop through every template in its config and, for each template, inject any records it creates based on criteria defined within the template itself.This allows consumers to define their own criteria for: