Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use safe load since 3.1 requires it #201

Merged
merged 1 commit into from Feb 8, 2022
Merged

use safe load since 3.1 requires it #201

merged 1 commit into from Feb 8, 2022

Conversation

idletea
Copy link
Contributor

@idletea idletea commented Feb 8, 2022

Ruby 3.0 or 3.1 uses Psych 4.0+, Psych 4.0+ uses safe_load as the default for YAML.load, so now YAML.load will refuse to deserialize, among other things, regexes, which are used in places like this.

Older versions of ruby won't recognize the permitted_classes keyword in load, so we have to use safe_load directly to make things worth across ruby versions.

@idletea idletea merged commit 721d9f0 into master Feb 8, 2022
@charlescng charlescng deleted the oefd/safe_load_yaml branch February 12, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants