Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dnsimple requirement from ~> 4.4.0 to >= 4.4, < 8.8 #214

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Update dnsimple requirement from ~> 4.4.0 to >= 4.4, < 8.8 #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
294aac7
Update dnsimple requirement from ~> 4.4.0 to >= 4.4, < 8.8
dependabot[bot] Dec 18, 2023
ddea99b
Update dnsimple requirement from ~> 4.4.0 to >= 4.4, < 8.8
dependabot[bot] Jan 18, 2024
53737c5
Fixes from error suggestions
anaclaudiar Jan 18, 2024
baf3d73
Merge branch 'dependabot/bundler/dnsimple-gte-4.4-and-lt-8.8' of http…
anaclaudiar Jan 18, 2024
3bdd3c8
Use delete_zone_record instead of delete_record
anaclaudiar Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/record_store/provider/dnsimple.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def empty_non_terminal_over_wildcard?
# returns an array of Record objects that match the records which exist in the provider
def retrieve_current_records(zone:, stdout: $stdout)
retry_on_connection_errors do
session.zones.all_records(account_id, zone).data.map do |record|
session.zones.all_zone_records(account_id, zone).data.map do |record|
build_from_api(record, zone)
rescue StandardError
stdout.puts "Cannot build record: #{record}"
Expand All @@ -40,7 +40,7 @@ def zones

def add(record, zone)
record_hash = api_hash(record, zone)
res = session.zones.create_record(account_id, zone, record_hash)
res = session.zones.create_zone_record(account_id, zone, record_hash)

if record.type == 'ALIAS'
txt_alias = retrieve_current_records(zone: zone).detect do |rr|
Expand All @@ -53,7 +53,7 @@ def add(record, zone)
end

def remove(record, zone)
session.zones.delete_record(account_id, zone, record.id)
session.zones.delete_zone_record(account_id, zone, record.id)
end

def update(id, record, zone)
Expand Down
2 changes: 1 addition & 1 deletion record_store.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'ejson'
spec.add_runtime_dependency 'thor', '>= 0.20.3', '< 1.4.0'

spec.add_runtime_dependency 'dnsimple', '~> 4.4.0'
spec.add_runtime_dependency 'dnsimple', '>= 4.4', '< 8.8'
spec.add_runtime_dependency 'fog-dynect', '>= 0.4', '< 0.6'
spec.add_runtime_dependency 'fog-json'
spec.add_runtime_dependency 'fog-xml'
Expand Down