Update documentation for sigil order cop #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EnforceSigilOrder cop originally preferred to put the `typed` sigil first, above the `encoding` sigil, which caused Ruby to ignore the `encoding` sigil if present. This was corrected in: 66b2d6f but the documentation was not updated in that same commit. This change updates the documentation in the cop to reflect the correct ordering of the sigils enforced by the cop.
|
I just signed the CLA as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EnforceSigilOrder cop originally preferred to put the
typedsigilfirst, above the
encodingsigil, which caused Ruby to ignore theencodingsigil if present. This was corrected in:66b2d6f
but the documentation was not updated in that same commit.
This change updates the documentation in the cop to reflect the correct
ordering of the sigils enforced by the cop.