Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable EmptyLineAfterSig in RBI config #188

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Enable EmptyLineAfterSig in RBI config #188

merged 2 commits into from
Oct 16, 2023

Conversation

sambostock
Copy link
Contributor

@sambostock sambostock commented Oct 15, 2023 •
edited

This teaches EmptyLineAfterSig to detect empty lines between signatures in RBIs where methods may have multiple signatures, and enables the cop in the rbi.yml config.

As per #185 (comment).

Before Merging

@sambostock sambostock requested a review from a team as a code owner October 15, 2023 21:24
@sambostock sambostock mentioned this pull request Oct 15, 2023
Merged
1 task
paracycle
paracycle approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from optimize-empty-line-after-sig to main October 16, 2023 01:50
@sambostock sambostock merged commit d94f631 into main Oct 16, 2023
12 checks passed
@sambostock sambostock deleted the empty-lines-in-rbis branch October 16, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

@Morriar Morriar Awaiting requested review from Morriar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sambostock @paracycle