Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain EnforceSigilOrder cop #233

Merged
merged 3 commits into from
May 23, 2024
Merged

Explain EnforceSigilOrder cop #233

merged 3 commits into from
May 23, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented May 23, 2024

Closes #232

@andyw8 andyw8 requested a review from a team as a code owner May 23, 2024 16:07
@andyw8 andyw8 requested review from Morriar and KaanOzkan May 23, 2024 16:07
@andyw8
Copy link
Contributor Author

andyw8 commented May 23, 2024

Is this clear @marknuzz?

@andyw8 andyw8 added the documentation Improvements or additions to documentation label May 23, 2024
andyw8 and others added 2 commits May 23, 2024 13:29
@andyw8 @Morriar
Update lib/rubocop/cop/sorbet/sigils/enforce_sigil_order.rb
bf25bfd 
Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
@andyw8
$ bundle exec rake generate_cops_documentation
486d1f5
@andyw8 andyw8 merged commit c5e7c41 into main May 23, 2024
11 checks passed
@andyw8 andyw8 deleted the andy8/explain-enforce-sigil-cop branch May 23, 2024 17:30
@marknuzz
Copy link

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morriar Morriar Morriar approved these changes

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain EnforceSigilOrder better in documentation
3 participants
@andyw8 @marknuzz @Morriar