Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude files in db/migrate from ForbidSuperclassConstLiteral #57

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Exclude files in db/migrate from ForbidSuperclassConstLiteral #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f414b56
Add exclude in ForbidSuperclassConstLiteral for migrations
Mar 16, 2021
c108e74
Fix typo
Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ Sorbet/ForbidSuperclassConstLiteral:
Description: 'Forbid superclasses which are non-literal constants.'
Enabled: false
VersionAdded: 0.2.0
VersionChanged: 0.5.0
VersionChanged: 0.6.1
Exclude:
- db/migrate/*.rb

Sorbet/ForbidUntypedStructProps:
Description: >-
Expand Down Expand Up @@ -99,7 +101,7 @@ Sorbet/KeywordArgumentOrdering:
Enabled: true
VersionAdded: 0.2.0

Sorbet/OnedAncestorPerLine:
RyanBrushett marked this conversation as resolved.
Show resolved Hide resolved
Sorbet/OneAncestorPerLine:
Description: 'Enforces one ancestor per call to requires_ancestor'
Enabled: false
VersionAdded: '0.6.0'
Expand Down
10 changes: 8 additions & 2 deletions manual/cops_sorbet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,16 @@ No documentation

Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
--- | --- | --- | --- | ---
Disabled | Yes | No | 0.2.0 | 0.5.0
Disabled | Yes | No | 0.2.0 | 0.6.1

No documentation

### Configurable attributes

Name | Default value | Configurable values
--- | --- | ---
Exclude | `db/migrate/*.rb` | Array

## Sorbet/ForbidUntypedStructProps

Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
Expand Down Expand Up @@ -296,7 +302,7 @@ def foo(b:, a: 1); end

Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
--- | --- | --- | --- | ---
Enabled | Yes | Yes | - | -
Disabled | Yes | Yes | 0.6.0 | -
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo was affecting our ability to generate the docs correctly.


This cop ensures one ancestor per requires_ancestor line
rather than chaining them as a comma-separated list.
Expand Down