Move DSL hover functionality from the Ruby LSP #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/add_dsl_hover
branch
from
a5781eb
to
56e2e38
Compare
andyw8
approved these changes
Aug 28, 2023
vinistock
force-pushed
the
vs/add_dsl_hover
branch
from
56e2e38
to
98f3cfe
Compare
Morriar
reviewed
Aug 29, 2023
| module Support | ||
| class RailsDocumentClient | ||
| RAILS_DOC_HOST = "https://api.rubyonrails.org" | ||
| SUPPORTED_RAILS_DOC_NAMESPACES = T.let( |
There was a problem hiding this comment.
Adding a space to be consistent with the next constant:
Suggested change
| SUPPORTED_RAILS_DOC_NAMESPACES = T.let( | |
| SUPPORTED_RAILS_DOC_NAMESPACES = T.let( |
Comment on lines
+33
to
+36
| extend T::Sig | ||
| sig do | ||
| params(name: String).returns(T::Array[String]) | ||
| end |
There was a problem hiding this comment.
Suggested change
| extend T::Sig | |
| sig do | |
| params(name: String).returns(T::Array[String]) | |
| end | |
| extend T::Sig | |
| sig { params(name: String).returns(T::Array[String]) } |
There was a problem hiding this comment.
I think this is such a common thing that we should have a cop for it? I can create an issue if there isn't one already.
There was a problem hiding this comment.
I don't think there's an issue for it. Not sure how common it is, but definitely good to maintain standards.
|
|
||
| response = Net::HTTP.get_response(URI("#{RAILS_DOC_HOST}/v#{RAILTIES_VERSION}/js/search_index.js")) | ||
|
|
||
| if response.code == "302" |
There was a problem hiding this comment.
In the docs they seem to favor comparing the class rather than the code:
case res
when Net::HTTPSuccess, Net::HTTPRedirection
# OK
else
res.value
end
|
Addressed the comments in #138. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Shopify/ruby-lsp#915, we are removing the Rails specific hover functionality in favour of the more generic one using the index. The Rails specific part should be in this extension.
This PR just moves the functionality in here. There's no difference other than how the tests are structured, since we don't have the same fixture mechanism in this extension.