Test against released Rails #224
Conversation
andyw8
force-pushed
the
andyw8/test-against-released-rails
branch
from
634603b
to
b812711
Compare
| ruby: ["3.0", "3.1", "3.2", "3.3", "head"] | ||
| include: | ||
| - ruby: "head" | ||
| experimental: true | ||
| - gemfile: "gemfiles/Gemfile-rails-main" | ||
| experimental: true | ||
| exclude: |
There was a problem hiding this comment.
To avoid the headache of Bundler platform changes.
| @@ -1,4 +1,4 @@ | |||
| class CreatePosts < ActiveRecord::Migration[7.2] | |||
| class CreatePosts < ActiveRecord::Migration[7.1] | |||
There was a problem hiding this comment.
I ran a search and replace for 7.2 to 7.1.
| @@ -9,13 +9,21 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| gemfile: | |||
| - Gemfile | |||
| - gemfiles/Gemfile-rails-main | |||
There was a problem hiding this comment.
I followed the same naming as in tapioca.
|
(The branch protection rules will need updated once this is merged - we will need to bypass them for now). |
| @@ -0,0 +1,22 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| source "https://rubygems.org" | |||
There was a problem hiding this comment.
Would it work if we used eval_gemfile to keep this one in sync with the top level? Or does it complain about rails appearing twice?
eval_gemfile("../Gemfile")
gem "rails", github: "rails/rails", branch: "main"There was a problem hiding this comment.
Yeah, it's complains:
There was an error parsing `Gemfile-rails-main`: You cannot specify the same gem twice coming from different sources.
but we could extract out the commonality, and call eval_gemfile from each?
(@Morriar do you have some approach for keeping these in sync on Tapioca?)
There was a problem hiding this comment.
In that case, I think it should probably be fine. We can always re-evaluate if it becomes difficult to maintain.
Another option would be using an environment variable to decide only the rails dependency.
if ENV["USE_RAILS_MAIN"]
gem "rails", github: "rails/rails", branch: "main"
else
gem "rails"
end
andyw8
force-pushed
the
andyw8/test-against-released-rails
branch
from
1954a2e
to
a4bff73
Compare
|
I've updated the branch protection rules. |
As discussed in #220