Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support document symbol on ActiveSupport tests #231

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jan 15, 2024

This feature allows users to navigate between AS tests with the Go to Symbol feature of VS Code.

It shares similar implementation with Code Lens around test case name extraction. And due to the complexity of the logic, I decided to extract it to a helper even though it's only shared between 2 components at the moment.

Demo

document_symbol

@st0012 st0012 force-pushed the document-symbol-poc branch 2 times, most recently from 84b8fab to b9b1ed8 Compare February 21, 2024 07:49
@st0012 st0012 changed the title DocumentSymbol PoC Support document symbol on ActiveSupport tests Feb 21, 2024
@st0012 st0012 force-pushed the document-symbol-poc branch 2 times, most recently from 033fce5 to 5b1e851 Compare February 21, 2024 08:23
@st0012 st0012 marked this pull request as ready for review February 21, 2024 08:32
@st0012 st0012 requested a review from a team as a code owner February 21, 2024 08:32
@st0012 st0012 added the enhancement New feature or request label Feb 21, 2024
@st0012 st0012 self-assigned this Feb 21, 2024
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

lib/ruby_lsp/ruby_lsp_rails/document_symbol.rb Outdated Show resolved Hide resolved
lib/ruby_lsp/ruby_lsp_rails/document_symbol.rb Outdated Show resolved Hide resolved
st0012 and others added 2 commits February 22, 2024 09:39
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
@st0012 st0012 merged commit 7b4de91 into main Feb 22, 2024
54 checks passed
@st0012 st0012 deleted the document-symbol-poc branch February 22, 2024 22:17
@andyw8
Copy link
Contributor

andyw8 commented Feb 22, 2024

Just a reminder that we have a theme to help keep the screen captures consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants