Update Hover and CodeLens as per refactored responses in Ruby LSP #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan-soni
force-pushed
the
as/refactor-response
branch
from
ad03383
to
41c8c29
Compare
st0012
approved these changes
Feb 12, 2024
andyw8
reviewed
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Ruby LSP version 0.14.0, we need to update the
HoverandCodeLensimplementations in the Rails add-on.These no longer extend the
Listenerclass, and now use the response builder.The associated tests have been updated, and these changes have been tested locally.