Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #259

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Update readme #259

merged 2 commits into from
Feb 16, 2024

Conversation

Earlopain
Copy link
Contributor

#256 got rid of the Rack app so this notice is not needed anymore. https://github.com/Shopify/ruby-lsp-rails?tab=readme-ov-file#how-it-works goes into a bit of the inner workings which I think should sufice.

I've also fixed what I think should have been a link but instead is rendered literally because of backticks.

@Earlopain Earlopain requested a review from a team as a code owner February 16, 2024 10:09
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@vinistock vinistock enabled auto-merge (squash) February 16, 2024 16:24
@vinistock vinistock merged commit ba16bf3 into Shopify:main Feb 16, 2024
28 checks passed
@Earlopain Earlopain deleted the update-readme branch February 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants