Add reloading for schema changes #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Mar 6, 2024
| @@ -215,10 +215,6 @@ def hover_on_source(source, position) | |||
| assert_nil(response.error) | |||
| response.response | |||
| end | |||
|
|
|||
| def dummy_root | |||
There was a problem hiding this comment.
Move into test_helper so that we can share.
andyw8
commented
Mar 6, 2024
| sig { params(changes: T::Array[{ uri: String, type: Integer }]).void } | ||
| def workspace_did_change_watched_files(changes) | ||
| if changes.any? do |change| | ||
| change[:uri].end_with?("db/schema.rb") || change[:uri].end_with?("structure.sql") |
There was a problem hiding this comment.
Normally we would only have to support db/structure.sql but in Shopify/shopify we have additional structure files.
vinistock
approved these changes
Mar 6, 2024
andyw8
commented
Mar 6, 2024
| def trigger_reload | ||
| warn("Reloading Rails application...") | ||
| send_notification("reload") | ||
| warn("Reloading Rails application complete") |
There was a problem hiding this comment.
@vinistock I realised it might be better to remove the second warn here, since that call is asynchronous?
There was a problem hiding this comment.
That makes sense. We can either remove it or turn the notification into a request and just return an OK from the server.
IMO, I'd go with the former. No need for extra complexity.
andyw8
force-pushed
the
andyw8/add-reloading-for-schema-changes
branch
from
ee951f7
to
7ceefbb
Compare
andyw8
commented
Mar 6, 2024
| warn("Reloading Rails application") | ||
| send_notification("reload") | ||
| rescue IncompleteMessageError | ||
| warn("Ruby LSP Rails failed to get model information: #{@stderr.read}") |
There was a problem hiding this comment.
Will correct this message.
andyw8
force-pushed
the
andyw8/add-reloading-for-schema-changes
branch
from
7ceefbb
to
5f93af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change goes along with Shopify/ruby-lsp#1464 in ruby-lsp.
Partly addresses #257
We register for changes to the schema files, and trigger a reload so as to get the latest column information. (Using the same mechanism that
reload!in the Rails console uses).