Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $stderr.puts instead of warn #285

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Use $stderr.puts instead of warn #285

merged 1 commit into from
Mar 8, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Mar 8, 2024

To prevent behaviour being affect by the VERBOSE setting, as mentioned here.

@andyw8 andyw8 force-pushed the andyw8/use-stderr-puts-instead-of-warn branch 3 times, most recently from 14aede4 to 558c9c5 Compare March 8, 2024 18:23
@andyw8 andyw8 force-pushed the andyw8/use-stderr-puts-instead-of-warn branch from 558c9c5 to e5b48b4 Compare March 8, 2024 18:23
@andyw8 andyw8 marked this pull request as ready for review March 8, 2024 18:24
@andyw8 andyw8 requested a review from a team as a code owner March 8, 2024 18:24
@andyw8 andyw8 mentioned this pull request Mar 8, 2024
Merged
@andyw8 andyw8 merged commit 04fca2a into main Mar 8, 2024
54 checks passed
@andyw8 andyw8 deleted the andyw8/use-stderr-puts-instead-of-warn branch March 8, 2024 18:48
@andyw8 andyw8 added the refactoring Internal changes that shouldn't impact behavior label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo egiurleo was automatically assigned from Shopify/ruby-dev-exp

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan was automatically assigned from Shopify/ruby-dev-exp

Assignees
No one assigned
Labels
refactoring Internal changes that shouldn't impact behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyw8 @vinistock