Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nilable param runtime type check in server #290

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix nilable param runtime type check in server #290

merged 1 commit into from
Mar 14, 2024

Conversation

vinistock
Copy link
Member

Closes #289

We sometimes pass nil into the params parameter, which fails runtime type checks. We need to make it nilable to prevent this from happening.

@vinistock vinistock added the bugfix This PR fixes an existing bug label Mar 14, 2024
@vinistock vinistock self-assigned this Mar 14, 2024
@vinistock vinistock requested a review from a team as a code owner March 14, 2024 13:34
@vinistock vinistock merged commit 641ab1e into main Mar 14, 2024
54 checks passed
@vinistock vinistock deleted the vs/fix_nilable_params branch March 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo egiurleo was automatically assigned from Shopify/ruby-dev-exp

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan was automatically assigned from Shopify/ruby-dev-exp

Assignees

@vinistock vinistock

Labels
bugfix This PR fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sortbet error in server.rb, execute()?
2 participants
@vinistock @andyw8