Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement document symbol for associations #293

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

aryan-soni
Copy link
Contributor

Implements the document symbol for various associations supported in Rails.

Any potential refactoring can be scoped out of this for now — this PR is focused on supporting the feature.

@aryan-soni aryan-soni added the enhancement New feature or request label Mar 15, 2024
@aryan-soni aryan-soni requested a review from a team as a code owner March 15, 2024 01:22
@andyw8
Copy link
Contributor

andyw8 commented Mar 15, 2024

Couple of observations when testing on Core:

  • We won't have symbols for accelerated_belongs_to. Not a big deal, and we can add if ever upstreamed to Rails.
  • I discovered an existing issue in shopify-cops (see backlink).

@aryan-soni aryan-soni force-pushed the as/document-symbol-associations branch from bf7161b to 69e0f0b Compare March 15, 2024 18:18
@aryan-soni aryan-soni force-pushed the as/document-symbol-associations branch from 69e0f0b to 089b09d Compare March 15, 2024 18:31
@aryan-soni aryan-soni merged commit 7d12d96 into main Mar 15, 2024
54 checks passed
@aryan-soni aryan-soni deleted the as/document-symbol-associations branch March 15, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants