Change symbol appearance for Rails macros #294
Conversation
| unless arg_receiver.is_a?(Prism::ConstantReadNode) || arg_receiver.is_a?(Prism::ConstantPathNode) | ||
| name = ":#{name}" | ||
| end |
There was a problem hiding this comment.
Aren't these conditions covered by the above already? What are we guarding against here?
There was a problem hiding this comment.
Is it possible for it to be a CallNode but for the receiver to not be one of these two? That seems to be what's being guarded against
There was a problem hiding this comment.
But don't we already guard this in the conditional above? If the receiver is not a ConstantReadNode or ConstantPathNode, then name will be nil and we'll skip, no?
There was a problem hiding this comment.
Yeah, that's correct. It would be better to change the line where we're skipping, but if we do proceed with that, my question still stands about whether there's other cases worth factoring in here.
There was a problem hiding this comment.
Yeah this can be removed now. I can't think of any other cases we would need.
| @@ -161,8 +161,12 @@ def handle_all_arg_types(node, message) | |||
| name = arg_receiver.full_name if arg_receiver.is_a?(Prism::ConstantPathNode) | |||
There was a problem hiding this comment.
Unrelated to your PR changes, but I just realized that these can also be merged, similar to here.
Edit: I'm referencing the code below, didn't select the whole thing when I made the initial comment
name = arg_receiver.name if arg_receiver.is_a?(Prism::ConstantReadNode)
name = arg_receiver.full_name if arg_receiver.is_a?(Prism::ConstantPathNode)
This changes how we display symbols for Rails macros, so that: