Add attr_readonly to list of Symbols #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
natematykiewicz
commented
Apr 15, 2024
Comment on lines
+158
to
+170
| test "correctly handles attr_readonly" do | ||
| response = generate_document_symbols_for_source(<<~RUBY) | ||
| class FooModel < ApplicationRecord | ||
| attr_readonly :foo | ||
| end | ||
| RUBY | ||
|
|
||
| assert_equal(1, response.size) | ||
| assert_equal("FooModel", response[0].name) | ||
| assert_equal(1, response[0].children.size) | ||
| assert_equal("attr_readonly :foo", response[0].children[0].name) | ||
| end | ||
|
|
There was a problem hiding this comment.
I wasn't sure if you wanted this test. I see that has_one, has_many, has_and_belongs_to_many are all untested and just fall under the belongs_to test basically. So maybe this test isn't necessary.
There was a problem hiding this comment.
Yeah, it's not essential, but I'm ok with keeping it for now.
KaanOzkan
requested review from
a team,
andyw8 and
st0012
and removed request for
KaanOzkan
andyw8
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312