Prefix bin/rails with ruby on Windows
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/prefix-bin-rails-for-windows
branch
from
18b777b
to
2468eea
Compare
vinistock
reviewed
Apr 29, 2024
| if Gem.win_platform? | ||
| "ruby " + BASE_COMMAND | ||
| else | ||
| BASE_COMMAND |
There was a problem hiding this comment.
How about we get rid of the constant? It seems that using the constant directly is not something we would want, so we can encapsulate the full command here.
andyw8
force-pushed
the
andyw8/prefix-bin-rails-for-windows
branch
from
2468eea
to
ebe0b61
Compare
vinistock
approved these changes
Apr 29, 2024
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #351, and documented here, we should prefix the
bin/railscall withrubyon Windows.