-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only require parts of Rails actually needed #60
Conversation
4d8bcd3
to
87a7453
Compare
Thanks for the contribution! Instead of completely removing all the parts that aren't used now, can we restrict our runtime dependencies and then add the other parts to the We may want to add functionality related to jobs for example, in which case we'd need to reintroduce the parts again. If we can restrict the dependencies of the gem, without losing the other parts for development, that'd be great. |
@vinistock sorry for the late response, I was on pat leave :). I'll rebase this later this week. Having to re-add parts of Rails explicitly to me felt like a good thing, so devs do not unintentionally add functionality relying on parts of the framework not declared as dependencies. |
I agree wit Bart, we should not add Rails in the Gemfile. |
I'm in the same boat as Bart. Our app only loads the parts of Rails we use, and using ruby-lsp-rails now forces us to load it all. I'm available to help make any changes to get this merged :) Thanks for the awesome gem! 💚 |
Rebased! Seems the CLA check is broken. |
@bdewater some dependencies seem downgraded in this PR and CI is failing due to dependency issues. Can you resolve it and push again? |
@st0012 should be good now :) |
In our app we don't need Action Cable/Text/Mailbox etc and we don't want to pull it in for this gem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍
In our app we don't need Action Cable/Text/Mailbox etc and we don't want to pull it in for this gem.
It would be nice to even make Active Record optional and have a pattern to only offer functionality for Rails components used in the consuming application.
Relates to #47 but is more of a quick fix - I think it's possible to depends on Railties alone but this solves my immediate problem.