Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced document highlight to the ruby-lsp #110

Open
vinistock opened this issue May 17, 2022 · 0 comments
Open

Add advanced document highlight to the ruby-lsp #110

vinistock opened this issue May 17, 2022 · 0 comments
Labels
enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale

Comments

@vinistock
Copy link
Member

Basic document highlight #87 followed what currently exists for Ruby, which is just highlighting simple occurrences of the same text without doing scope resolution.

Advanced document highlight means that only occurrences of the same entity should be highlighted. This means that if some name is shadowed, we still only highlight the correct instances of the entity.

Example

def foo
  a = 1 # <<- clicking on `a` here should highlight only the last `a` on this method, but not the block argument, which shadows the variable name

  [1, 2, 3].each do |a| # <<- not highlighted
    puts a # <<- not highlighted
  end

  a + 2 # <<- highlighted
end
@vinistock vinistock mentioned this issue Jul 15, 2022
@vinistock vinistock added enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale labels Jul 20, 2023
andyw8 pushed a commit to andyw8/ruby-lsp that referenced this issue Mar 2, 2024
…ypescript-eslint/parser-5.27.1

Bump @typescript-eslint/parser from 5.27.0 to 5.27.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale
Projects
None yet
Development

No branches or pull requests

1 participant