Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document highlight does not highlight definitions #165

Closed
vinistock opened this issue Jun 24, 2022 · 0 comments · Fixed by #187
Closed

Document highlight does not highlight definitions #165

vinistock opened this issue Jun 24, 2022 · 0 comments · Fixed by #187
Assignees
Labels
enhancement New feature or request

Comments

@vinistock
Copy link
Member

Because we're checking if the node type matches exactly, we are not highlighting some legitimate occurrences of symbols. For example,

class Foo; end

Foo # <-- clicking here will not highlight the Foo in the class definition, but it should

The same thing happens for other types of definitions, like methods and modules.

@vinistock vinistock added the enhancement New feature or request label Jun 24, 2022
@vinistock vinistock self-assigned this Jul 5, 2022
@vinistock vinistock mentioned this issue Jul 15, 2022
andyw8 pushed a commit to andyw8/ruby-lsp that referenced this issue Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant