Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for handling did change configuration to the ruby-lsp #205

Closed
vinistock opened this issue Jul 15, 2022 · 1 comment
Closed

Comments

@vinistock
Copy link
Member

We allow users to configure the desired features from the VS Code plugin. However, it currently requires starting the LSP for the configuration changes to take effect.

We can use the didChangeConfiguration notification to verify if a feature has been enabled or disabled and then notify the client by unregistering or registering a capability without requiring a full restart.

Documentation: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_didChangeConfiguration

@vinistock vinistock mentioned this issue Jul 15, 2022
@vinistock
Copy link
Member Author

These notifications have actually been deprecated in favour of a pull model (i.e.: the server asking the client for specific configurations).

In that new model, I don't think this is feasible, so we might just need to continue restarting the server when a configuration is changed.

@vinistock vinistock closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2023
andyw8 pushed a commit to andyw8/ruby-lsp that referenced this issue Mar 2, 2024
…ypescript-4.8.2

Bump typescript from 4.7.4 to 4.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant