Migrate to YARP #1025
Merged
Migrate to YARP #1025
+6,623
−16,904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate CodeLens to YARP
Co-authored-by: Andy Waite <andyw8@users.noreply.github.com>
Co-authored-by: Andy Waite <andyw8@users.noreply.github.com>
Co-authored-by: Alexandre Terrasa <Morriar@users.noreply.github.com>
* Migrate DocumentLink to YARP * Only parse comments where needed * Fix type * PR feedback * Fix argument order * Re-enable DocumentLink integration test --------- Co-authored-by: Andy Waite <andyw8@users.noreply.github.com>
* Re-generate YARP RBIs * Re-enable tests * Fix typechecking errors
andyw8
reviewed
Sep 18, 2023
andyw8
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #449
Closes #859
This huge PR migrates the entire LSP to use YARP. The work was completed step by step merging into the
yarp-cleanbranch. This PR is just the final step to merge it into main.