Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1863, closes #1866, closes #1858
There were two issues with our previous implementation of RVM activation:
rvm-auto-ruby
was not setting environment variables as expected. I must have done something wrong, because it does set variables properly. This is really important for RVM because it overridesGEM_HOME
andGEM_PATH
, which means we can't rely on Ruby's defaults/usr/local/rvm
and not just~/.rvm
Implementation
Automated Tests
Changed the existing tests.