Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement None and Custom as version manager objects #1878

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Implement None and Custom as version manager objects #1878

merged 2 commits into from
Apr 5, 2024

Conversation

vinistock
Copy link
Member

Motivation

Migrate the final two activation modes None and Custom to version manager objects. After this goes, we can apply a bunch of refactors to the Ruby class now that every manager has been standardized to the same interface.

Implementation

  1. None just invokes Ruby and injects whatever environment exists
  2. Custom runs the defined script and then invokes Ruby to do the same

Automated Tests

Added tests for both.

@vinistock vinistock added enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes labels Apr 3, 2024
@vinistock vinistock self-assigned this Apr 3, 2024
@vinistock vinistock requested a review from a team as a code owner April 3, 2024 19:30
@vinistock vinistock requested review from andyw8 and st0012 April 3, 2024 19:30
@vinistock vinistock force-pushed the vs/migrate_remaining_managers branch from 7630df7 to 8bd6aef Compare April 3, 2024 19:53
@vinistock vinistock force-pushed the vs/migrate_remaining_managers branch from f65716b to 373b5bb Compare April 3, 2024 20:47
Base automatically changed from vs/enable_no_floating_promises to main April 5, 2024 17:33
@vinistock vinistock force-pushed the vs/migrate_remaining_managers branch from 373b5bb to 01ebc1a Compare April 5, 2024 17:34
@vinistock vinistock merged commit 9f3505a into main Apr 5, 2024
39 checks passed
@vinistock vinistock deleted the vs/migrate_remaining_managers branch April 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@st0012 st0012 Awaiting requested review from st0012 st0012 was automatically assigned from Shopify/ruby-dev-exp

Assignees

@vinistock vinistock

Labels
enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinistock @andyw8