Remove verbose or debug environment variables from Ruby env #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
st0012
approved these changes
Apr 5, 2024
vinistock
force-pushed
the
vs/better_sanitize_activated_environment
branch
from
1dbf3b2
to
5332e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1397
It looks like we may have finally discovered what causes Bundler to print stuff to STDOUT. It seems that other extensions insert
VERBOSE=1orDEBUG=warninto the NodeJS process env, which then enables verbose mode on Bundler.I'm still a bit confused as to why setting the
Bundler.ui.leveltosilentdoesn't prevent this, but I think we can sanitize the environment and remove these variables like we do for GC tuning variables.Implementation
Automated Tests
Added a test to verify that we remove those variables.